Skip to content

Conversation

uvNikita
Copy link
Contributor

Proposed change

Adding support for more Philips Hue lights. Original PR: #3664

Additional information

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.20%. Comparing base (5556090) to head (5a1dbf1).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4076   +/-   ##
=======================================
  Coverage   91.19%   91.20%           
=======================================
  Files         335      335           
  Lines       10886    10889    +3     
=======================================
+ Hits         9928     9931    +3     
  Misses        958      958           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheJulianJES TheJulianJES changed the title Add Philips Hue lights Expose 'multicolor' command on more Hue lights May 19, 2025
@TheJulianJES TheJulianJES merged commit 6b505b7 into zigpy:dev May 19, 2025
9 checks passed
@uvNikita uvNikita deleted the philips/add-lights branch May 21, 2025 06:41
@uvNikita uvNikita restored the philips/add-lights branch June 2, 2025 09:25
@uvNikita uvNikita deleted the philips/add-lights branch June 2, 2025 09:25
@Orange-GT3
Copy link

@uvNikita - I realise that this commit has been merged but I have other lights that I think could be added. Is it is simple as repeating lines 124-134 for each new device with the specific data in the applies_to, model and manufacturer variables?

@uvNikita
Copy link
Contributor Author

@Orange-GT3 yes, should be as simple as that. You can try to add your devices and open another PR.

@Orange-GT3
Copy link

@Orange-GT3 yes, should be as simple as that. You can try to add your devices and open another PR.

PR 4318 is now open for merging adding the Discover Floodlight, the Akari Downlight and the Hue Solo Lightstrip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants